CKEDITOR.plugins.add(ꞌpbckcodeꞌ).init - Code Metrics - Inspection of "Base developer template set" - itstructure/yii2-template-multilanguage - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( fe7b3f...22651e )

by Andrey

created 2019-07-05 12:52 UTC

CKEDITOR.plugins.add(ꞌpbckcodeꞌ).init B

↳ Parent: web/plugins/pbckcode/plugin.js

Complexity

Conditions	3
Paths	4

Size

Total Lines	82
Code Lines	43

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	43
nc	4
nop	1
dl	0
loc	82
c	0
b	0
f	0
cc	3
rs	8.8478

How to fix Long Method

// needed js files
var js = {
  ace: 'ace.js',
  aceExtWhitespace: 'ext-whitespace.js',
  pbSyntaxHighlighter: CKEDITOR.plugins.getPath('pbckcode') + 'dialogs/PBSyntaxHighlighter.js'

};

var commandName = 'pbckcode';

/**
 * Plugin definition
 */
CKEDITOR.plugins.add('pbckcode', {
  icons: 'pbckcode',
  hidpi: true,
  lang: ['fr', 'en', 'ru'],
  init: function(editor) {
    // if there is no user settings
    // create an empty object
    if (editor.config.pbckcode === undefined) {
      editor.config.pbckcode = {};
    }

    // default settings object
    var DEFAULT_SETTINGS = {
      cls: '',
      modes: [
        ['HTML', 'html'],
        ['CSS', 'css'],
        ['PHP', 'php'],
        ['JS', 'javascript']
      ],
      theme: 'textmate',
      tab_size: 4,
      js: '//cdnjs.cloudflare.com/ajax/libs/ace/1.2.6/'
    };

    // merge user settings with default settings
    editor.settings = CKEDITOR.tools.extend(DEFAULT_SETTINGS, editor.config.pbckcode, true);

    editor.settings.js = normalizeJsUrl(editor.settings.js);

    // load CSS for the dialog
    editor.on('instanceReady', function() {
      CKEDITOR.document.appendStyleSheet(this.path + 'dialogs/style.css');

    }.bind(this));

    // add the button in the toolbar
    editor.ui.addButton('pbckcode', {
      label: editor.lang.pbckcode.addCode,
      command: commandName,
      toolbar: 'pbckcode'
    });

    // link the button to the command
    editor.addCommand(commandName, new CKEDITOR.dialogCommand('pbckcodeDialog', {
        allowedContent: 'pre[*]{*}(*)'
      })
    );

    // disable the button while the required js files are not loaded
    editor.getCommand(commandName).disable();

    // add the plugin dialog element to the plugin
    CKEDITOR.dialog.add('pbckcodeDialog', this.path + 'dialogs/pbckcode.js');

    // add the context menu
    if (editor.contextMenu) {
      editor.addMenuGroup('pbckcodeGroup');
      editor.addMenuItem('pbckcodeItem', {
        label: editor.lang.pbckcode.editCode,
        icon: this.path + 'icons/pbckcode.png',
        command: commandName,
        group: 'pbckcodeGroup'
      });

      editor.contextMenu.addListener(function(element) {
        if (element.getAscendant('pre', true)) {
function isBig(a) {
    if (a > 5000) {
        return "yes";
    }
}

console.log(isBig(5001)); //returns yes
console.log(isBig(42)); //returns undefined
          return {pbckcodeItem: CKEDITOR.TRISTATE_OFF};

        }
      });
    }

    var scripts = [
      getScriptUrl(editor.settings.js, js.ace),
      js.pbSyntaxHighlighter
    ];

    // Load the required js files
    // enable the button when loaded
    CKEDITOR.scriptLoader.load(scripts, function() {
      editor.getCommand(commandName).enable();

      // need ace to be loaded
      CKEDITOR.scriptLoader.load([

        getScriptUrl(editor.settings.js, js.aceExtWhitespace)
      ]);
    });
  }
});

function normalizeJsUrl(js) {
  return js.concat('/')
    .replace(new RegExp('([^:]\/)\/+', 'g'), '$1');
}

function getScriptUrl(prefix, scriptName) {
  return prefix + scriptName;
}



1			// needed js files
2			var js = {
3			ace: 'ace.js',
4			aceExtWhitespace: 'ext-whitespace.js',
5			pbSyntaxHighlighter: CKEDITOR.plugins.getPath('pbckcode') + 'dialogs/PBSyntaxHighlighter.js'
			0 ignored issues – show Bug introduced 2019-05-11 18:25 UTC by Report Bug Copy Issue Report The variable `CKEDITOR` seems to be never declared. If this is a global, consider adding a `/** global: CKEDITOR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
6			};
7
8			var commandName = 'pbckcode';
9
10			/**
11			* Plugin definition
12			*/
13			CKEDITOR.plugins.add('pbckcode', {
14			icons: 'pbckcode',
15			hidpi: true,
16			lang: ['fr', 'en', 'ru'],
17			init: function(editor) {
18			// if there is no user settings
19			// create an empty object
20			if (editor.config.pbckcode === undefined) {
21			editor.config.pbckcode = {};
22			}
23
24			// default settings object
25			var DEFAULT_SETTINGS = {
26			cls: '',
27			modes: [
28			['HTML', 'html'],
29			['CSS', 'css'],
30			['PHP', 'php'],
31			['JS', 'javascript']
32			],
33			theme: 'textmate',
34			tab_size: 4,
35			js: '//cdnjs.cloudflare.com/ajax/libs/ace/1.2.6/'
36			};
37
38			// merge user settings with default settings
39			editor.settings = CKEDITOR.tools.extend(DEFAULT_SETTINGS, editor.config.pbckcode, true);
			0 ignored issues – show Bug introduced 2019-05-11 18:25 UTC by Report Bug Copy Issue Report The variable `CKEDITOR` seems to be never declared. If this is a global, consider adding a `/** global: CKEDITOR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
40			editor.settings.js = normalizeJsUrl(editor.settings.js);
41
42			// load CSS for the dialog
43			editor.on('instanceReady', function() {
44			CKEDITOR.document.appendStyleSheet(this.path + 'dialogs/style.css');
			0 ignored issues – show Bug introduced 2019-05-11 18:25 UTC by Report Bug Copy Issue Report The variable `CKEDITOR` seems to be never declared. If this is a global, consider adding a `/** global: CKEDITOR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
45			}.bind(this));
46
47			// add the button in the toolbar
48			editor.ui.addButton('pbckcode', {
49			label: editor.lang.pbckcode.addCode,
50			command: commandName,
51			toolbar: 'pbckcode'
52			});
53
54			// link the button to the command
55			editor.addCommand(commandName, new CKEDITOR.dialogCommand('pbckcodeDialog', {
56			allowedContent: 'pre[]{}(*)'
57			})
58			);
59
60			// disable the button while the required js files are not loaded
61			editor.getCommand(commandName).disable();
62
63			// add the plugin dialog element to the plugin
64			CKEDITOR.dialog.add('pbckcodeDialog', this.path + 'dialogs/pbckcode.js');
65
66			// add the context menu
67			if (editor.contextMenu) {
68			editor.addMenuGroup('pbckcodeGroup');
69			editor.addMenuItem('pbckcodeItem', {
70			label: editor.lang.pbckcode.editCode,
71			icon: this.path + 'icons/pbckcode.png',
72			command: commandName,
73			group: 'pbckcodeGroup'
74			});
75
76			editor.contextMenu.addListener(function(element) {
77			if (element.getAscendant('pre', true)) {
			0 ignored issues – show Complexity Best Practice introduced 2019-05-11 18:25 UTC by Report Bug Copy Issue Report There is no return statement if `element.getAscendant("pre", true)` is `false`. Are you sure this is correct? If so, consider adding `return;` explicitly. This check looks for functions where a `return` statement is found in some execution paths, but not in all. Consider this little piece of code function isBig(a) { if (a > 5000) { return "yes"; } } console.log(isBig(5001)); //returns yes console.log(isBig(42)); //returns undefined The function `isBig` will only return a specific value when its parameter is bigger than 5000. In any other case, it will implicitly return `undefined`. This behaviour may not be what you had intended. In any case, you can add a `return undefined` to the other execution path to make the return value explicit. Loading history...
78			return {pbckcodeItem: CKEDITOR.TRISTATE_OFF};
			0 ignored issues – show Bug introduced 2019-05-11 18:25 UTC by Report Bug Copy Issue Report The variable `CKEDITOR` seems to be never declared. If this is a global, consider adding a `/** global: CKEDITOR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
79			}
80			});
81			}
82
83			var scripts = [
84			getScriptUrl(editor.settings.js, js.ace),
85			js.pbSyntaxHighlighter
86			];
87
88			// Load the required js files
89			// enable the button when loaded
90			CKEDITOR.scriptLoader.load(scripts, function() {
91			editor.getCommand(commandName).enable();
92
93			// need ace to be loaded
94			CKEDITOR.scriptLoader.load([
			0 ignored issues – show Bug introduced 2019-05-11 18:25 UTC by Report Bug Copy Issue Report The variable `CKEDITOR` seems to be never declared. If this is a global, consider adding a `/** global: CKEDITOR */` comment. This checks looks for references to variables that have not been declared. This is most likey a typographical error or a variable has been renamed. To learn more about declaring variables in Javascript, see the MDN. Loading history...
95			getScriptUrl(editor.settings.js, js.aceExtWhitespace)
96			]);
97			});
98			}
99			});
100
101			function normalizeJsUrl(js) {
102			return js.concat('/')
103			.replace(new RegExp('([^:]\/)\/+', 'g'), '$1');
104			}
105
106			function getScriptUrl(prefix, scriptName) {
107			return prefix + scriptName;
108			}
109
110

itstructure / yii2-template-multilanguage

Push — master ( fe7b3f...22651e )

CKEDITOR.plugins.add(ꞌpbckcodeꞌ).init B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like